Repository navigation
docs(ducklake): correct the embedded DuckDB version per release line - #2187
Merged
Merged
Conversation
Spice embeds DuckDB v1.4.4 on trunk (spiceai/spiceai#13742 downgraded it from 1.5.5 on 2026-08-30, shipping in v2.2.1). The DuckLake pages claimed 1.5.3. - vNext catalog page: 1.5.3 -> 1.4.4 (mirrors the connector page fixed in #2186) - version-2.2.x: v2.2.1 embeds 1.4.4, v2.2.0 embeds 1.5.5 - version-2.1.x: v2.1.2+ embeds 1.5.5, v2.1.0/v2.1.1 embed 1.5.3 - version-2.0.x left unchanged: v2.0.0/v2.0.1 really do embed 1.5.3
Contributor
✅ Pull with Spice PassedPassing checks:
|
Contributor
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
1 similar comment
Contributor
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
Contributor
|
🚀 deployed to https://0210e389.spiceai-org-website.pages.dev |
lukekim
approved these changes
Sep 10, 2026
4 tasks done
lukekim
pushed a commit
that referenced
this pull request
Sep 12, 2026
The version-2.3.x snapshot was cut hours before #2187 corrected the embedded DuckDB version per release line, so its catalog page still claims DuckDB 1.5.3 while the connector page in the same snapshot already says 1.4.4. v2.3.0's Cargo.toml pins the crate whose comment names DuckDB v1.4.4.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The DuckLake pages claim DuckDB 1.5.3. That value is right only for the v2.0.x line; every other release line embeds a different DuckDB, and trunk embeds 1.4.4.
Cargo.tomlon trunk is explicit about the mapping between theduckdbcrate version and the DuckDB library version, which is what makes this checkable — the crate versions are not the DuckDB versions:Reading that comment at each release tag gives:
The vNext connector page was corrected to 1.4.4 in #2186; this PR sweeps the sibling catalog page it missed, plus every versioned snapshot that carries the same claim.
What changed
website/docs/components/catalogs/ducklake.md— 1.5.3 → 1.4.4, wording matched to the connector page docs: reconcile the docs with the runtime changes since v2.2 #2186 already fixed.versioned_docs/version-2.2.x/(connector + catalog) — "Spice v2.2.1 embeds DuckDB 1.4.4; v2.2.0 embeds DuckDB 1.5.5".versioned_docs/version-2.1.x/(connector + catalog) — "Spice v2.1.2 and later embed DuckDB 1.5.5; v2.1.0 and v2.1.1 embed DuckDB 1.5.3".The version changed inside the 2.1.x and 2.2.x lines, so a single flat number is wrong for part of each line's readership — hence the per-patch wording rather than just swapping one digit.
Source refs
Cargo.tomlat v2.2.1 / at v2.2.0 / at v2.1.5 / at v2.1.1Out of scope
The versioned pages also assert "which supports DuckLake 1.0". #2186 dropped that clause from the vNext connector page rather than restate it, and I have no runnable evidence for which DuckLake catalog version each DuckDB build accepts, so I left the clause alone on the snapshots instead of guessing.
Test plan
cd website && npm run buildpassesgrep -rn "DuckDB 1.5.3" website/now returns only the two v2.0.x files, which are correct