Skip to content

test: unskip unfinished update handler cases on time-skipping server - #1697

Merged
tconley1428 merged 1 commit into
temporalio:mainfrom
Sakshamm-Goyal:agent/unskip-time-skipping-update-826
Jul 30, 2026
Merged

test: unskip unfinished update handler cases on time-skipping server#1697
tconley1428 merged 1 commit into
temporalio:mainfrom
Sakshamm-Goyal:agent/unskip-time-skipping-update-826

Conversation

@Sakshamm-Goyal

Copy link
Copy Markdown
Contributor

Summary

  • unskip the unfinished-handler matrix for the time-skipping environment
  • accept the documented NOT_FOUND update-poll outcome when a continue-as-new interrupts an unfinished update handler
  • preserve the existing WorkflowUpdateFailedError assertion for servers that report the aborted update as an outcome

The workflow runtime warning already documents that interrupted update handlers can cause clients to receive workflow execution already completed; the time-skipping server exposes that path directly.

Validation

  • pytest tests/worker/test_workflow.py::test_unfinished_handler_on_workflow_termination -q --workflow-environment time-skipping (48 passed)
  • pytest tests/worker/test_workflow.py::test_unfinished_handler_on_workflow_termination -q (48 passed)
  • ruff format --check tests/worker/test_workflow.py
  • python -m compileall -q tests/worker/test_workflow.py

Closes #826.

@Sakshamm-Goyal
Sakshamm-Goyal requested a review from a team as a code owner July 30, 2026 15:09
@Sakshamm-Goyal
Sakshamm-Goyal force-pushed the agent/unskip-time-skipping-update-826 branch from 380d167 to ee16c0e Compare July 30, 2026 16:17
@Sakshamm-Goyal
Sakshamm-Goyal force-pushed the agent/unskip-time-skipping-update-826 branch from ee16c0e to 9629fc9 Compare July 30, 2026 17:26
@Sakshamm-Goyal

Copy link
Copy Markdown
Contributor Author

CI exposed one additional static check after unskipping this parametrized test: its env fixture was no longer used, so BasedPyright treated it as a warning and the lint sequence failed. I removed only that unused parameter in 9629fc9. The complete 48-case time-skipping matrix, Ruff formatting, Mypy, and BasedPyright all pass locally; CI is rerunning on the repaired head.

@tconley1428
tconley1428 merged commit 1295930 into temporalio:main Jul 30, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] test_unfinished_handler_on_workflow_termination fails in some situations with time skipping and update

2 participants