test: unskip unfinished update handler cases on time-skipping server - #1697
Merged
tconley1428 merged 1 commit intoJul 30, 2026
Merged
Conversation
Sakshamm-Goyal
force-pushed
the
agent/unskip-time-skipping-update-826
branch
from
July 30, 2026 16:17
380d167 to
ee16c0e
Compare
Sakshamm-Goyal
force-pushed
the
agent/unskip-time-skipping-update-826
branch
from
July 30, 2026 17:26
ee16c0e to
9629fc9
Compare
Contributor
Author
|
CI exposed one additional static check after unskipping this parametrized test: its |
tconley1428
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NOT_FOUNDupdate-poll outcome when a continue-as-new interrupts an unfinished update handlerWorkflowUpdateFailedErrorassertion for servers that report the aborted update as an outcomeThe workflow runtime warning already documents that interrupted update handlers can cause clients to receive
workflow execution already completed; the time-skipping server exposes that path directly.Validation
pytest tests/worker/test_workflow.py::test_unfinished_handler_on_workflow_termination -q --workflow-environment time-skipping(48 passed)pytest tests/worker/test_workflow.py::test_unfinished_handler_on_workflow_termination -q(48 passed)ruff format --check tests/worker/test_workflow.pypython -m compileall -q tests/worker/test_workflow.pyCloses #826.