Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions tests/worker/test_workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -6725,7 +6725,6 @@ async def my_dynamic_signal(self, _name: str, _args: Sequence[RawValue]) -> None
)
async def test_unfinished_handler_on_workflow_termination(
client: Client,
env: WorkflowEnvironment,
handler_type: Literal["-signal-", "-update-"],
handler_registration: Literal["-late-registered-", "-not-late-registered-"],
handler_dynamism: Literal["-dynamic-", "-not-dynamic-"],
Expand All @@ -6736,10 +6735,6 @@ async def test_unfinished_handler_on_workflow_termination(
"-cancellation-", "-failure-", "-continue-as-new-"
],
):
if env.supports_time_skipping:
pytest.skip(
"Issues with update: https://github.com/temporalio/sdk-python/issues/826"
)
skip_unfinished_handler_tests_in_older_python()
await _UnfinishedHandlersOnWorkflowTerminationTest(
client,
Expand Down Expand Up @@ -6832,13 +6827,24 @@ async def _run_workflow_and_get_warning(self) -> bool:
if self.handler_waiting == "-wait-all-handlers-finish-":
await update_task
else:
with pytest.raises(WorkflowUpdateFailedError) as err_info:
with pytest.raises(
(WorkflowUpdateFailedError, RPCError)
) as err_info:
await update_task
update_err = err_info.value
assert isinstance(update_err.cause, ApplicationError)
assert (
update_err.cause.type == "AcceptedUpdateCompletedWorkflow"
)
if isinstance(update_err, WorkflowUpdateFailedError):
assert isinstance(update_err.cause, ApplicationError)
assert (
update_err.cause.type
== "AcceptedUpdateCompletedWorkflow"
)
else:
assert isinstance(update_err, RPCError)
assert update_err.status == RPCStatusCode.NOT_FOUND
assert (
str(update_err)
== "workflow execution already completed"
)

with pytest.raises(WorkflowFailureError) as err:
await handle.result()
Expand Down
Loading