Skip to content

feat(bfv)!: size the BFV parameter search for 45 parties - #2535

Merged
ctrlc03 merged 0 commit into
large/node-measurefrom
large/params-n45
Nov 20, 2026
Merged

ctrlc03 merged 0 commit into
large/node-measurefrom
large/params-n45

Conversation

@ctrlc03

@ctrlc03 ctrlc03 commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

Split from #2398 (Zara's work). Stacked on #2533 (large/c4-per-limb); review that one first.

The BFV parameter search was sized for 19 parties (insecure 20/19). The Large committee needs
correct noise bounds for 45 parties, so this raises the search to n = 45 before any committee is
defined.

  • SEARCH_N is 45 for the secure and insecure searches, and the error-1 variance constants and the
    builder test vectors follow the new search result.
  • The regenerated Noir threshold configs, BfvProtocol.sol and crypto-config.json carry the new
    parameter hashes (insecure 0x2898f8a9…a844, secure 0x4f402598…08c3) and the config IDs that
    derive from them. bfv_protocol.json and bfv_profiles.json are recomputed independently with
    ethers, not copied from the generator.
  • The search tests pin n = 20 and n = 19 where they test the old size. The crate README, the
    witness sample test and the indexer's fake Interfold fixture follow.
  • The tuples keep registry indices 0 and 2 here. docs/architecture/upgrades.md records why live
    registries cannot take them there; feat(bfv)!: register the 45-party parameter sets at indices 3 and 4 #2539 moves them to indices 3 and 4.
  • No committee is added here: the committee set is unchanged.

Verification

Static checks only; CI runs the tests.

  • cargo check --workspace --lib --bins, cargo check --all-targets for the affected crates,
    cargo fmt --check.
  • nargo check of lib, bin/config, bin/threshold and bin/dkg with the secure parameters,
    scripts/circuits/lint.sh, node scripts/blueprint/check.mjs, pnpm check:bindings,
    node scripts/circuits/crypto-config.mjs --check --sources, prettier.
  • The fixtures were recomputed with ethers and match the Rust generator's output.

Compatibility

Breaking within the unreleased protocol-9 cutover (no separate counter change): every pair's
parameter hash and cryptoConfigId change, and with them the verification keys and verifiers.

@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
interfold-dashboard Ready Ready Preview Nov 20, 2026 9:12am UTC
interfold-docs Ready Ready Preview Nov 20, 2026 9:12am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 2

  • main
  • dev

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ctrlc03
ctrlc03 added this pull request to stack #2538 November 20, 2026 08:50
@ctrlc03
ctrlc03 removed this pull request from stack #2538 November 20, 2026 09:11
@ctrlc03
ctrlc03 merged commit 2072bd1 into large/node-measure Nov 20, 2026
9 of 12 checks passed
@ctrlc03

ctrlc03 commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator Author

Auto-merged into a stack branch by GitHub during the restack; nothing reached main. Continued in #2542.

This branch was successfully deployed

2 active deployments
Preview – interfold-dashboard — 2072bd14 Deployed Nov 20, 2026 by vercel[bot]
Preview – interfold-docs — 2072bd14 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant