Repository navigation
feat(bfv)!: size the BFV parameter search for 45 parties - #2535
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 2
Please check the settings in the CodeRabbit UI or the
|
ctrlc03
force-pushed
the
large/node-measure
branch
from
November 19, 2026 22:58
5aceb96 to
928ef4c
Compare
ctrlc03
force-pushed
the
large/params-n45
branch
from
November 19, 2026 22:58
6d37d70 to
84d9282
Compare
ctrlc03
force-pushed
the
large/node-measure
branch
from
November 19, 2026 23:30
928ef4c to
34e4460
Compare
ctrlc03
force-pushed
the
large/params-n45
branch
from
November 19, 2026 23:30
84d9282 to
ff0afea
Compare
ctrlc03
force-pushed
the
large/node-measure
branch
from
November 20, 2026 08:50
34e4460 to
92be035
Compare
ctrlc03
force-pushed
the
large/params-n45
branch
from
November 20, 2026 08:50
ff0afea to
9493eaa
Compare
ctrlc03
force-pushed
the
large/params-n45
branch
from
November 20, 2026 09:11
9493eaa to
2072bd1
Compare
ctrlc03
force-pushed
the
large/node-measure
branch
from
November 20, 2026 09:11
92be035 to
e91dd2c
Compare
Collaborator
Author
|
Auto-merged into a stack branch by GitHub during the restack; nothing reached main. Continued in #2542. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Split from #2398 (Zara's work). Stacked on #2533 (
large/c4-per-limb); review that one first.The BFV parameter search was sized for 19 parties (insecure 20/19). The Large committee needs
correct noise bounds for 45 parties, so this raises the search to n = 45 before any committee is
defined.
SEARCH_Nis 45 for the secure and insecure searches, and the error-1 variance constants and thebuilder test vectors follow the new search result.
BfvProtocol.solandcrypto-config.jsoncarry the newparameter hashes (insecure
0x2898f8a9…a844, secure0x4f402598…08c3) and the config IDs thatderive from them.
bfv_protocol.jsonandbfv_profiles.jsonare recomputed independently withethers, not copied from the generator.
witness sample test and the indexer's fake Interfold fixture follow.
docs/architecture/upgrades.mdrecords why liveregistries cannot take them there; feat(bfv)!: register the 45-party parameter sets at indices 3 and 4 #2539 moves them to indices 3 and 4.
Verification
Static checks only; CI runs the tests.
cargo check --workspace --lib --bins,cargo check --all-targetsfor the affected crates,cargo fmt --check.nargo checkoflib,bin/config,bin/thresholdandbin/dkgwith the secure parameters,scripts/circuits/lint.sh,node scripts/blueprint/check.mjs,pnpm check:bindings,node scripts/circuits/crypto-config.mjs --check --sources, prettier.Compatibility
Breaking within the unreleased protocol-9 cutover (no separate counter change): every pair's
parameter hash and
cryptoConfigIdchange, and with them the verification keys and verifiers.0 and 2 (
setParamSetis append-only). feat(bfv)!: register the 45-party parameter sets at indices 3 and 4 #2539 resolves that; land the two together.circuits/vk-commitments.json), the Solidity verifiers, the BFV VK-bindingfixture and the layout-lock fixtures are regenerated once, from one matrix build, in chore(circuits): regenerate the circuit outputs of the large stack #2541 (
large/circuit-outputs), near the top ofthe stack. Until then this PR's circuit, verifier and layout-lock checks
fail by design.