Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Split from #2398. Raise the secure-8192 and insecure-64 search to n = 45 (rerun of search_params, the insecure one with lambda 2 and 12-bit primes), so one parameter set serves every committee up to the large one. The moduli are unchanged; the threshold error1 variance grows (secure B_Enc 518814677073081139200, insecure 460800), so the smudging and user-encryption e0 bounds grow, and the insecure e0 bound gains one bit. Correctness margins at n = 45: secure 2.07 bits, insecure 2.52 bits. Both presets' parameter hashes and every configuration identity change (BfvProtocol.sol, crypto-config.json and the independently recomputed ethers fixtures). Compiled artifacts, the VK catalogue and the BFV verifiers are regenerated separately.
…xture The indexer fixture contract returns the insecure BFV crypto config ID. The ID changed with the 45-party parameters, so the fixture follows the value in bfv_protocol.json.
The 45-party search changes the threshold tuples at registry indices 0 and 2. Registration is append-only, and Mainnet index 2 and Sepolia indices 0 and 2 already hold the v0.19 tuples, so those deployments cannot take the new bytes in place. State the consequences for requests, nodes and the indexer, and the two rollout options. The decision stays open for human review.
ctrlc03
force-pushed
the
large/params-n45
branch
from
November 20, 2026 09:48
2072bd1 to
9365aa1
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Split from #2398 (Zara's work). Stacked on #2533 (
large/c4-per-limb); review that one first.Replaces #2535, which GitHub auto-merged into a stack branch during the restack; its review
threads stay there.
The BFV parameter search was sized for 19 parties (insecure 20/19). The Large committee needs
correct noise bounds for 45 parties, so this raises the search to n = 45 before any committee is
defined.
SEARCH_Nis 45 for the secure and insecure searches, and the error-1 variance constants and thebuilder test vectors follow the new search result.
BfvProtocol.solandcrypto-config.jsoncarry the newparameter hashes (insecure
0x2898f8a9…a844, secure0x4f402598…08c3) and the config IDs thatderive from them.
bfv_protocol.jsonandbfv_profiles.jsonare recomputed independently withethers, not copied from the generator.
witness sample test and the indexer's fake Interfold fixture follow.
docs/architecture/upgrades.mdrecords why liveregistries cannot take them there; feat(bfv)!: register the 45-party parameter sets at indices 3 and 4 #2539 moves them to indices 3 and 4.
Verification
Static checks only; CI runs the tests.
cargo check --workspace --lib --bins,cargo check --all-targetsfor the affected crates,cargo fmt --check.nargo checkoflib,bin/config,bin/thresholdandbin/dkgwith the secure parameters,scripts/circuits/lint.sh,node scripts/blueprint/check.mjs,pnpm check:bindings,node scripts/circuits/crypto-config.mjs --check --sources, prettier.Compatibility
Breaking within the unreleased protocol-9 cutover (no separate counter change): every pair's
parameter hash and
cryptoConfigIdchange, and with them the verification keys and verifiers.0 and 2 (
setParamSetis append-only). feat(bfv)!: register the 45-party parameter sets at indices 3 and 4 #2539 resolves that; land the two together.circuits/vk-commitments.json), the Solidity verifiers, the BFV VK-bindingfixture and the layout-lock fixtures are regenerated once, from one matrix build, in chore(circuits): regenerate the circuit outputs of the large stack #2541 (
large/circuit-outputs), near the top ofthe stack. Until then this PR's circuit, verifier and layout-lock checks
fail by design.