Handle idempotent response on tarball upload url - #109
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling idempotent upload requests in the registry client. When a package upload has already been completed, the server now returns a message field instead of an id/url, which is treated as a successful operation rather than an error.
- Changed
UploadTarballResponsefields from strings to pointers to support optional fields - Added
Messagefield to handle idempotent response scenarios - Introduced
idempotencyRespErrorcustom error type for special success handling of duplicate uploads
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cli/registry/client/client.go | Modified UploadTarballResponse to use pointer types for Id and Url, added optional Message field for idempotency responses |
| cli/command/publish/publish.go | Added idempotencyRespError type, updated response handling to check for idempotency message and display success, adjusted nil checks for pointer fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the package is already published, we need to ensure idempotency for the same user. This PR adds changes to bail early with idempotent response once the package is published for the same user.