Skip to content

Handle idempotent response on tarball upload url #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thelovekesh merged 1 commit into from
Nov 7, 2025
Merged

Handle idempotent response on tarball upload url #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions cli/command/publish/publish.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,14 @@ type tarballSizeCounter struct {
total int64
}

type idempotencyRespError struct {
message string
}

func (e *idempotencyRespError) Error() string {
return e.message
}

func (c *tarballSizeCounter) Write(p []byte) (n int, err error) {
c.total += int64(len(p))
return len(p), nil
Expand Down Expand Up @@ -219,13 +227,17 @@ func runPublish(wpmCli command.Cli, opts publishOptions) error {
if err != nil {
return err
}
if resp.Id == "" {
if resp.Message != nil {
return &idempotencyRespError{message: *resp.Message}
}

if resp.Id == nil {
Comment thread
thelovekesh marked this conversation as resolved.
return errors.New("failed to get request id from upload response")
}
reqId = resp.Id
reqId = *resp.Id

if resp.Url != "" {
req, err := http.NewRequestWithContext(context.Background(), http.MethodPut, resp.Url, tempTarball)
if resp.Url != nil {
req, err := http.NewRequestWithContext(context.Background(), http.MethodPut, *resp.Url, tempTarball)
if err != nil {
return err
}
Expand Down Expand Up @@ -254,7 +266,12 @@ func runPublish(wpmCli command.Cli, opts publishOptions) error {
wpmCli.Err(),
)
if err != nil {
return errors.Wrap(err, "failed to upload tarball to registry")
if _, ok := err.(*idempotencyRespError); ok {
fmt.Fprintf(wpmCli.Err(), "🚀 %s 🚀\n", aec.GreenF.Apply(err.Error()))
return nil
}

return err
Comment thread
thelovekesh marked this conversation as resolved.
}

readmeText, err := readme(cwd)
Expand Down
7 changes: 5 additions & 2 deletions cli/registry/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,11 @@ type UploadTarballOptions struct {

// UploadTarballResponse defines the response structure for uploading a package.
type UploadTarballResponse struct {
Id string `json:"id"`
Url string `json:"url"`
Id *string `json:"id"`
Url *string `json:"url"`

// In case of idempotent requests, the message field may contain information.
Message *string `json:"message,omitempty"`
}

func (c *client) GetUploadTarballUrl(ctx context.Context, opts UploadTarballOptions) (UploadTarballResponse, error) {
Expand Down
Loading