fix(block-ui): center PDF net labels - #178
Open
Sang-it wants to merge 3 commits into
Open
Conversation
svg2pdf ignores dominant-baseline and reads alignment-baseline. Mirror the value during export without overriding explicit alignment.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jsPDF renders its middle baseline above the browser SVG position. Apply an em-relative correction without overriding explicit dy values.
Keep the SVG compatibility logic isolated and apply the visually verified 0.08em central-baseline correction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before:
After:
dominant-baselineintoalignment-baselinebefore svg2pdf conversion0.08emin text-local coordinatesdypositioning across text and tspan elementsWhy
svg2pdf.js ignores
dominant-baseline, while jsPDF renders the mapped middle baseline slightly above the browser SVG position. Together these differences vertically offset generated PDF net labels.Testing
bun run format:checkbun run typecheckbun testbun run build