Repository navigation
Get System-Level Testing Working - #200
Closed
schwarz-em wants to merge 15 commits into
Closed
schwarz-em wants to merge 15 commits into
schwarz-em wants to merge 15 commits into
Conversation
The RX path drives pl_valid for one cycle per accepted beat, so the test can no longer expect it to stay high until rxActiveReq drops.
MBInitSM runs the test with PERLANEID, but the requester only decoded VALTRAIN and LFSR, so the per-lane results stayed at their zero default and lane repair could never trigger. Decoding them exposes a second bug: PatternReader reports per-lane PASS flags and MBInitSM read them as faults, which degraded every lane and pushed the link into TRAINERROR. Both have to change together. The two asserts that only allowed VALTRAIN or LFSR now allow PERLANEID, and the one requiring an idle PatternReader is scoped to the cycle the request is made, since the reader is started inside that same state.
The clock handshake runs again while RDI is ACTIVE whenever sideband traffic needs clocks, so the wake and clock prerequisites are a condition for entering ACTIVE rather than an invariant across it. The three pl_clk_req assertions also fired a cycle early, because the requester needs one cycle to leave sIDLE.
The layers were disabled because the TX point test asserted on the pattern type MBINIT drives. With that fixed the three ladders pass with every assertion live.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This integrates the KAIST fixes for things that were hitting assertions + random bugfixes (some scrambler syncing, patterns stuck in the rx queue... etc)
A simple test writing 40B across a ucie port in loopback on Iris passes