Conversation
chris-ashe
left a comment
chris-ashe
left a comment
There was a problem hiding this comment.
Few comments, you also need to update the docs and give a reference. Please put the reference in IEEE style with a hyperlink DOI
| ), | ||
| "fiooic": InputVariable( | ||
| data_structure.constraint_variables, float, range=(0.001, 1.0) | ||
| data_structure.constraint_variables, float, range=(0.001, 10.0) |
There was a problem hiding this comment.
Why has this been changed?
There was a problem hiding this comment.
This was changed to allow a fudge factor during some future concepts scans
|
|
||
| if physics_variables.i_plasma_geometry == 12: | ||
|
|
||
| physics_variables.kappa = 2.93e0 * ( 1.8e0 / physics_variables.aspect ) ** 0.4e0 |
There was a problem hiding this comment.
A comment with the model origin needs to be added
There was a problem hiding this comment.
I'm slightly unclear on the definitive source of the this scaling.
There was a problem hiding this comment.
I will see if I can hunt it down
| elif physics_variables.i_plasma_geometry == 12: | ||
| po.ovarrf( | ||
| self.outfile, | ||
| "Elongation, X-point (calculated from aspect ratio via scaling)", |
There was a problem hiding this comment.
The string needs to state the model
timothy-nunn
left a comment
timothy-nunn
left a comment
There was a problem hiding this comment.
Thanks @chris-ashe for the review. @ajpearcey please fix the merge conflicts so that the CI can run and I can review any failures there
ajpearcey
force-pushed
the
i_plasma_geo_12
branch
from
6dc2bd9 to
330e980
Compare
chris-ashe
left a comment
chris-ashe
left a comment
There was a problem hiding this comment.
@ajpearcey Can you please update the docs and add a reference in IEE format with a clickable DOI link
ajpearcey
force-pushed
the
i_plasma_geo_12
branch
from
f202321 to
9e5c020
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4134 +/- ##
==========================================
- Coverage 52.10% 52.10% -0.01%
==========================================
Files 148 148
Lines 30389 30393 +4
==========================================
Hits 15835 15835
- Misses 14554 14558 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chris-ashe
force-pushed
the
i_plasma_geo_12
branch
from
7de4d9e to
e1bac33
Compare
timothy-nunn
left a comment
timothy-nunn
left a comment
There was a problem hiding this comment.
Please talk to @chris-ashe about the enums. Happy otherwise once Chris approves!
| 79: "eta_ecrh_injector_wall_plug", | ||
| 80: "fcoolcp", | ||
| 81: "n_tf_coil_turns", | ||
| 82: "f_p_plasma_separatrix_rad", # really fradpwr |
There was a problem hiding this comment.
| 82: "f_p_plasma_separatrix_rad", # really fradpwr | |
| 82: "f_p_plasma_separatrix_rad", |
|
|
||
| # ====================================================================== | ||
|
|
||
| if physics_variables.i_plasma_geometry == 12: |
There was a problem hiding this comment.
Then use the new enum here
| physics_variables.kappa, | ||
| "OP ", | ||
| ) | ||
| elif physics_variables.i_plasma_geometry == 12: |
| 79: "eta_ecrh_injector_wall_plug", | ||
| 80: "fcoolcp", | ||
| 81: "n_tf_coil_turns", | ||
| 82: "f_p_plasma_separatrix_rad", # really fradpwr |
There was a problem hiding this comment.
| 82: "f_p_plasma_separatrix_rad", # really fradpwr | |
| 82: "f_p_plasma_separatrix_rad", |
| 50: "f_nd_impurity_electrons(13)", | ||
| 51: "f_p_div_lower", | ||
| 52: "rad_fraction_sol", | ||
| 53: "obsolete", # Removed |
There was a problem hiding this comment.
| 53: "obsolete", # Removed | |
| 53: "Obsolete", # OBSOLETE |
ajpearcey
force-pushed
the
i_plasma_geo_12
branch
from
5f8ff4d to
e09bb29
Compare
4 participants
add new relationship for elongation v aspect ratio. Validated for low aspect ratio ST devices.