Repository navigation
feat: add Brazilian Portuguese localization - #300
Merged
Merged
Conversation
Contributor
Author
|
I noticed #295 after opening this PR, so I want to avoid duplicating effort. I reviewed the maintainer feedback there and updated this branch accordingly:
All Rust tests and the Windows UI script checks pass locally. If you would prefer to continue with #295 instead, I am happy to close this one. Otherwise, this PR should now cover the remaining Windows pt-BR gaps mentioned there. |
vinzdg
added a commit
that referenced
this pull request
Sep 22, 2026
Resolving the notch.html conflict by keeping both sides dropped the closing brace of TEXT.ko and the closing bracket of PATTERNS.ko, so the pt-BR tables were nested inside the Korean ones and the page did not parse. A page that does not parse opens empty with nothing in the log, which is what check-ui-scripts.mjs exists to catch — and did. Verified structurally as well as syntactically: TEXT, PATTERNS and UI each carry ko and pt-BR with their own key counts.
This was referenced Sep 22, 2026
3 tasks done
2 of 4 tasks
abhishekthakur7
pushed a commit
to abhishekthakur7/codenotch
that referenced
this pull request
Sep 28, 2026
pt-BR rather than pt, matching the Mac catalog and so the lang value written to config.json — the same person gets the same language on both ports. One fix on top: 'pt-BR' was missing from the LANGS whitelist, so choosing Português (Brasil) was discarded on save and read back as 'auto'. The language was unreachable from the picker that offered it. LANGS and the <option> list now agree. Thanks @dinicleyaguiar.
abhishekthakur7
pushed a commit
to abhishekthakur7/codenotch
that referenced
this pull request
Sep 28, 2026
Resolving the notch.html conflict by keeping both sides dropped the closing brace of TEXT.ko and the closing bracket of PATTERNS.ko, so the pt-BR tables were nested inside the Korean ones and the page did not parse. A page that does not parse opens empty with nothing in the log, which is what check-ui-scripts.mjs exists to catch — and did. Verified structurally as well as syntactically: TEXT, PATTERNS and UI each carry ko and pt-BR with their own key counts.
abhishekthakur7
pushed a commit
to abhishekthakur7/codenotch
that referenced
this pull request
Sep 28, 2026
pt-BR rather than pt, matching the Mac catalog and so the lang value written to config.json — the same person gets the same language on both ports. One fix on top: 'pt-BR' was missing from the LANGS whitelist, so choosing Português (Brasil) was discarded on save and read back as 'auto'. The language was unreachable from the picker that offered it. LANGS and the <option> list now agree. Thanks @dinicleyaguiar.
abhishekthakur7
pushed a commit
to abhishekthakur7/codenotch
that referenced
this pull request
Sep 28, 2026
Resolving the notch.html conflict by keeping both sides dropped the closing brace of TEXT.ko and the closing bracket of PATTERNS.ko, so the pt-BR tables were nested inside the Korean ones and the page did not parse. A page that does not parse opens empty with nothing in the log, which is what check-ui-scripts.mjs exists to catch — and did. Verified structurally as well as syntactically: TEXT, PATTERNS and UI each carry ko and pt-BR with their own key counts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Brazilian Portuguese (pt-BR) localization to the Windows version of Codenotch.
Changes
Validation
Notes
This change is scoped to the Windows localization system and follows the existing language-table structure.