Repository navigation
Give uk and ko the #288 move-handle pair, and sweep the dead pill key - #318
Merged
Merged
Conversation
…ll key UK_STATIC was missing the two strings vinzdg#288 added (Show move handle, the arc caption) — both now render translated, using the Ukrainian already authoritative in the Mac catalog. UK_STATIC and KO_STATIC both carried a dead key from the old Recentre caption, which no current page text matches; dropped from both rather than re-pointed, since each already has the new caption's translation. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Sep 22, 2026
This was referenced Sep 23, 2026
abhishekthakur7
pushed a commit
to abhishekthakur7/codenotch
that referenced
this pull request
Sep 28, 2026
abhishekthakur7
pushed a commit
to abhishekthakur7/codenotch
that referenced
this pull request
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small follow-up from your review on #295 — you flagged that
UK_STATICwas missing the two strings #288 added, and thatUK_STATICcarried a dead key from the old Recentre caption.UK_STATICnow hasShow move handleand the arc caption, translated. The Ukrainian for both already exists in the Mac catalog (Sources/Localizable.xcstrings), so this is a straight transport, not a translation.The pill can be dragged up and down the right-hand edge...) is dropped fromUK_STATIC. It no longer matches any live text since the Recentre caption was reworded, and it isn't in the Mac catalog either.KO_STATICalready had the Fold the Windows notch to a pill when not in use, as the Mac's Show on hover does #288 pair (landed after your email, in "Add Korean on Windows") but carried the same dead key — dropped that too.Net result:
UK_STATICandKO_STATICboth at 87 live keys, 0 dead, matchingZH_STATIC.Also noticed while auditing (not touched here, flagging only)
RU_STATICis missing 31 keys andJA_STATICis missing 13 — mostly short control labels (Left,Right,Small,Off,Close...) in Russian, and the whole Edge/Screen placement block in Japanese. Both render in English today.ZH_HANT_STATIC's translation of the Fold the Windows notch to a pill when not in use, as the Mac's Show on hover does #288 pair diverges slightly from the Mac catalog's wording for the same strings (顯示移動手柄 vs 顯示移動握把) — might be a deliberate Windows-side choice, just flagging.Test plan
node scripts/check-ui-scripts.mjs— all three UI pages still parsecargo test --locked— 131 passed, includingtraymenu::tests::the_card_and_the_menu_agree_on_window_namescargo build --release; verified in the running app that Show move handle and the arc caption render translated under Українська, and that no English leaks through under 한국어🤖 Generated with Claude Code