Repository navigation
bugfix: Restore notches on external displays after sleep/wake - #431
Open
itradesize wants to merge 1 commit into
Open
itradesize wants to merge 1 commit into
itradesize wants to merge 1 commit into
Conversation
itradesize
force-pushed
the
fix/display-wake-reconciliation
branch
from
October 9, 2026 17:00
d783ea7 to
9e1d8cb
Compare
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After sleep/wake or a display topology change, macOS can replace
NSScreeninstances while preserving their display identifiers.In All displays mode,
NotchFleetretained existing controllersbased on stable display keys, but did not update their assigned
NSScreenreferences.As a result, controllers could fall back to the preferred display,
causing multiple notch panels to appear on the same monitor.
Root cause
The issue was reproduced on a four-display setup.
Diagnostic logging confirmed:
NSScreen.screens.Fix
NSScreeninstance.No wake-specific delays, timers, or polling were introduced.
Tests
Added regression coverage for:
NSScreeninstances with stable display keys.Validation
make build: PASSmake test: 2,122 passed, 6 skipped, 1 failed.The single failure is a pre-existing hardware-dependent test:
EverySizeSettingAppliesEverywhereTests.testTheSizeSettingSurvivesTheHardwareEdge()The same failure was confirmed on the clean baseline before this change.
Physical validation was performed on a four-display Mac setup.
The original issue was reproduced before the fix, and subsequent
real-world sleep/wake testing confirmed correct display assignments.