Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23986.
Use
path.win32.normalize()for paths beginning with//, then convert the result to forward slashes. This preserves Windows device and UNC roots, includingnode:vfsmount points. Other paths keep the existing POSIX normalization.Regression tests cover device/UNC paths, relative segments, trailing separators, idempotence, native Windows separators, POSIX filenames, and reading a mounted
node:vfsfile through its normalized path.Validation
pnpm buildpnpm --filter vite typecheckENOENT; the fixed implementation passes all 1,124 unit testsAI assistance
A coding agent prepared the implementation and tests and ran the checks above. The approach delegates namespace handling to Node rather than reconstructing path prefixes manually; the before/after Windows run verifies that normalized paths still address the same mounted memory files.