fix(fs): avoid recursive semantic refresh on resource delete#2971
Open
fujiajie666 wants to merge 1 commit into
Open
fix(fs): avoid recursive semantic refresh on resource delete#2971fujiajie666 wants to merge 1 commit into
fujiajie666 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deleting a resource folder enqueues a semantic refresh for the parent directory so
the parent's overview reflects the deleted child. However,
_enqueue_delete_refresh()created the
SemanticMsgwithout overriding its defaultrecursive=True.That caused a delete under
viking://resourcesto recursively re-process unrelatedsibling folders, creating thousands of unnecessary embedding tasks, API 429s, health
check timeouts, and token waste.
This PR makes delete refresh messages non-recursive, so only the parent directory is
refreshed while existing child/sibling abstracts are reused.
Related Issue
Fixes #2959
Type of Change
Changes Made
fs_service.py: setrecursive=Falsewhen enqueueing delete refreshSemanticMsgTesting
Local verification:
uv run --extra test pytest -q tests/service/test_fs_service.py