Skip to content

fix(fs): avoid recursive semantic refresh on resource delete #2971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qin-ctx merged 1 commit into from
Jul 3, 2026
Merged

fix(fs): avoid recursive semantic refresh on resource delete #2971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions openviking/service/fs_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,7 @@ async def _enqueue_delete_refresh(
msg = SemanticMsg(
uri=root_uri,
context_type=context_type,
recursive=False,
account_id=ctx.account_id,
user_id=ctx.user.user_id,
peer_id=ctx.user.user_id,
Expand Down
1 change: 1 addition & 0 deletions tests/service/test_fs_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,7 @@ async def test_resource_rm_wait_registers_request_before_semantic_root(
assert tracker.registered_requests == ["tm-fs-rm"]
assert tracker.registered_roots
assert tracker.registered_roots[0]["request_was_registered"] is True
assert queue_manager.messages[0].recursive is False
assert tracker.wait_calls == [("tm-fs-rm", 3)]
assert tracker.cleaned == ["tm-fs-rm"]
assert result["semantic_status"] == "complete"
Expand Down