feat: Add support for passing arbitrary parameters to the ID assertio… #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm1
reviewed
Jul 24, 2025
| : <dfn>fields</dfn> | ||
| :: The list of fields that the [=RP=] has requested in {{IdentityProviderRequestOptions/fields}}. | ||
| : <dfn>params</dfn> | ||
| :: The arbitrary parameters that the [=RP=] has requested in {{IdentityProviderRequestOptions/params}}. |
Collaborator
There was a problem hiding this comment.
Might be good to explain how the params are sent here (it is serialized to a JSON string)
Collaborator
There was a problem hiding this comment.
These are already added in the current spec version, see https://w3c-fedid.github.io/FedCM/#idp-api-id-assertion-endpoint. Can you rebase this PR and let me know if there is anything else you want to add? I noticed fields and params are missing from https://w3c-fedid.github.io/FedCM/#browser-api-credential-request-options, perhaps add something there?
Collaborator
|
Actually this is already updated in the latest spec (hence the merge conflict). I think this PR can be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n endpoint
Preview | Diff