Skip to content

feat: Add support for passing arbitrary parameters to the ID assertio… #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tylorjohnson09 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add support for passing arbitrary parameters to the ID assertio… #766

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2707c9b
feat: Add support for passing arbitrary parameters to the ID assertio…
google-labs-jules[bot] Jul 24, 2025
e9733db
Merge branch 'main' into add-params-to-assertion-endpoint
tylorjohnson09 Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spec/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2383,10 +2383,10 @@ It will also contain the following parameters in the request body `application/x
:: The [=RP=]'s unique identifier from the [=IDP=].
: <dfn>account_id</dfn>
:: The account identifier that was selected.
: <dfn>is_auto_selected</dfn>
:: A boolean indicating whether the account was automatically selected as opposed to being actively chosen by the user.
: <dfn>fields</dfn>
:: The list of fields that the [=RP=] has requested in {{IdentityProviderRequestOptions/fields}}.
: <dfn>params</dfn>
:: A serialized JSON object provided by the RP that can have an arbitrary structure and content.
:: The arbitrary parameters that the [=RP=] has requested in {{IdentityProviderRequestOptions/params}}.
Copy link
Collaborator

@npm1 npm1 Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to explain how the params are sent here (it is serialized to a JSON string)

Copy link
Author

@tylorjohnson09 tylorjohnson09 Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I fix it right

Copy link
Collaborator

@npm1 npm1 Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are already added in the current spec version, see https://w3c-fedid.github.io/FedCM/#idp-api-id-assertion-endpoint. Can you rebase this PR and let me know if there is anything else you want to add? I noticed fields and params are missing from https://w3c-fedid.github.io/FedCM/#browser-api-credential-request-options, perhaps add something there?

</dl>

<div class="issue" heading="extension">
Expand Down