Fix Ruby 4.0 warning in default before_template and after_template#986
Merged
joeldrapper merged 1 commit intoJul 14, 2026
Conversation
…pt a block
The call site in SGML#call passes a block to both methods via `&block`,
but the default no-op implementations had no block parameter. Ruby 4.0
warns about this ("block passed to method may be ignored"). Adding `(&)`
to both signatures silently accepts the block without using it.
ErnaneJ
force-pushed
the
fix/ruby4-block-warning-before-after-template
branch
from
July 14, 2026 03:36
032d92e to
f230f2e
Compare
Collaborator
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #985
SGML#callpasses the caller's block tobefore_templateandafter_templatevia&block, but the default no-op implementations had no block parameter. Ruby 4.0 warns about this:I added
(&)to both signatures so they accept the block without binding it to a variable. Subclasses that override these methods won't be affected.