Skip to content

Fix Ruby 4.0 warning in default before_template and after_template #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeldrapper merged 1 commit into from
Jul 14, 2026
+7 −2
Merged

Fix Ruby 4.0 warning in default before_template and after_template #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/phlex/sgml.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,11 +326,11 @@ def json_escape(string)
nil
end

private def before_template
private def before_template(&)
nil
end

private def after_template
private def after_template(&)
nil
end

Expand Down
5 changes: 5 additions & 0 deletions quickdraw/sgml/callbacks.test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,9 @@ def view_template
test "callbacks are called in the correct order" do
assert_equal Example.call, "<i>1</i><i>2</i><i>3</i><i>4</i><i>5</i><i>6</i><i>7</i>"
end

test "default before_template and after_template accept a block" do
klass = Class.new(Phlex::HTML) { def view_template = span { "hello" } }
assert_equal klass.call { "ignored" }, "<span>hello</span>"
end
end
Loading