Skip to content

menu: fix Clone button and launch updates in Console - #294

Merged
BenWestgate merged 1 commit into
masterfrom
claude/project-thread-dxqxwj
Oct 3, 2026
Merged

BenWestgate merged 1 commit into
masterfrom
claude/project-thread-dxqxwj

Conversation

@BenWestgate

@BenWestgate BenWestgate commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

Requested by Ben · project thread

Before: in the CipherStick menu, Clone did nothing (it called bails-clone, which doesn't exist), and Settings → Update Bitcoin Core and Update CipherStick did nothing on Tails 7, because they launched gnome-terminal, which Tails 7.0 replaced with GNOME Console.

After: Clone runs bails-cloner (which currently shows its "Coming soon" dialog), and both update actions open in GNOME Console (kgx) with the same titles.

How: one-word rename in the Clone case, and gnome-terminal … --hide-menubar -- swapped for kgx --title=… -- (Console has no menubar option). Master has been merged in since #202 landed, so the Wallet and Sparrow entries stay removed. shellcheck 0.9.0 with the CI options passes.

Related: #260 rewrites these same lines (it runs updates without a terminal but still calls bails-clone); #219 hides Clone for #42.

🤖 Generated with Claude Code

https://claude.ai/code/session_01CtyDBLAPkZctBPN5U2EjCV

@BenWestgate BenWestgate self-assigned this Sep 30, 2026

Copy link
Copy Markdown
Owner Author

github-advanced-security is red here, but not because of this PR. The same check fails on every PR in this repo because the Copilot model set in the repo settings is no longer supported ("model not supported"). There's no code fix to port. It will go green once the model is changed in the repository's Copilot settings. The shellcheck lint result is what matters for this change.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

CodeQL / Analyze (python) fails here, but the cause isn't in this PR, and the same check is red on master at 99b4a3a (run). #202 removed the repo's last .py files, and #230 doesn't add any back. With no Python left, CodeQL ends with "configuration error". python is the only language in .github/workflows/codeql.yml, so the fix is to retire that workflow, or switch it to actions so it scans the workflow files instead. I haven't found an open PR that does this yet. That repo-wide CI change is better made separately than added to this menu fix. Re-running wouldn't help because the failure is deterministic.


Generated by Claude Code

@BenWestgate
BenWestgate marked this pull request as ready for review October 1, 2026 08:50
@chatgpt-codex-connector

This comment has been minimized.

bails-menu called bails-clone, but the script is named bails-cloner,
so the Clone button failed with "command not found".

The Update Bitcoin Core and Update CipherStick actions launched
gnome-terminal. Tails 7 replaced GNOME Terminal with GNOME Console
(kgx), so both buttons did nothing. Launch them with kgx instead,
keeping the same window titles. Console has no menubar option, so
--hide-menubar is dropped.

Claude-Session: https://claude.ai/code/session_01CtyDBLAPkZctBPN5U2EjCV
@BenWestgate
BenWestgate force-pushed the claude/project-thread-dxqxwj branch from 1013f1f to 43d7925 Compare October 1, 2026 08:51
@BenWestgate
BenWestgate merged commit 575e193 into master Oct 3, 2026
4 of 5 checks passed
@BenWestgate
BenWestgate deleted the claude/project-thread-dxqxwj branch October 3, 2026 09:48
BenWestgate added a commit that referenced this pull request Oct 7, 2026
Open links with xdg-open and show the URL if that fails, return to
the menu after Help and Settings actions, use zenity --icon, and
drop the stale Slack and Twitter links.

Updates keep running in GNOME Console as master does since #294,
so a user can watch and cancel them.

Closes #252
Refs #249, #269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants