Skip to content

menu: Hide unfinished backup actions - #219

Draft
BenWestgate wants to merge 1 commit into
masterfrom
42-disable-backup-clone
Draft

BenWestgate wants to merge 1 commit into
masterfrom
42-disable-backup-clone

Conversation

@BenWestgate

@BenWestgate BenWestgate commented Sep 19, 2026 •

Copy link
Copy Markdown
Owner

Requested by Ben · project thread

Rebase note: Rebased onto master on 2026-10-07. It conflicted with #294 (merged), which pointed Clone at bails-cloner. That script only shows "Coming soon", so this PR still hides both Clone and Backup.

Status

Replayed cleanly onto the current wallet-removal base. Current head 97f5f6e is one commit, mergeable, and Lint CI is green.

What

  • hide the unfinished Backup and Clone actions from the CipherStick menu
  • remove README instructions that direct users to the hidden Clone flow
  • preserve the base branch's newer legacy-wallet/Codex32-removal wording and current desktop description

Why

Those actions are not implemented safely enough to expose to users and can leave an installation in a broken state. The earlier branch had drifted behind its base; this rebuild keeps only the focused #42 UI/docs removals.

Closes #42

Review scope

One commit, two files, +2/−20 against the current base.

Testing

  • git diff --check
  • bash -n bails/.local/bin/bails-menu
  • all current review threads resolved
  • Lint CI passes on 97f5f6e

@chatgpt-codex-connector

This comment has been minimized.

@BenWestgate

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

This comment has been minimized.

@BenWestgate
BenWestgate force-pushed the 42-disable-backup-clone branch from 3e65380 to 5e5851e Compare September 21, 2026 08:33
@BenWestgate

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e5851e35b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bails/.local/bin/bails-menu Outdated

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-generated review (Claude), posted at the maintainer's request.

ACK c99f244

  • Menu, desktop entry and README are consistent. ibd-progress still calls bails-backup, but nothing invokes ibd-progress any more, so it's dormant.
  • Conflicts with #202 and #234 (same menu lines). Land #202 first and rebase.

@BenWestgate
BenWestgate changed the base branch from master to 201-simplify-this-project-by-removing-bails-wallet September 28, 2026 00:02
@BenWestgate
BenWestgate force-pushed the 42-disable-backup-clone branch 2 times, most recently from 20d9998 to 97f5f6e Compare September 29, 2026 23:52
BenWestgate added a commit that referenced this pull request Sep 29, 2026
Stack the documentation-only security-claim cleanup after #219 so the docs do not advertise Clone/Backup while declaring those flows unsupported. Preserve the writing supplies still required by Persistent Storage setup and retire unsafe legacy FAQ guidance.

Closes #211
@BenWestgate
BenWestgate force-pushed the 201-simplify-this-project-by-removing-bails-wallet branch from 06922fb to 0a3f5f2 Compare September 30, 2026 01:31
@BenWestgate
BenWestgate force-pushed the 42-disable-backup-clone branch from 97f5f6e to cd3146e Compare September 30, 2026 01:41
@chatgpt-codex-connector

This comment has been minimized.

BenWestgate added a commit that referenced this pull request Sep 30, 2026
Replace absolute privacy/security claims with bounded descriptions of the supported installer, distinguish current and unsupported functionality, and remove linked recovery guidance for the retired legacy wallet/clone flows.

Closes #211
Refs #42, #215, #219
Base automatically changed from 201-simplify-this-project-by-removing-bails-wallet to master October 1, 2026 01:24
@chatgpt-codex-connector

This comment has been minimized.

@BenWestgate
BenWestgate force-pushed the 42-disable-backup-clone branch from 2ffbebe to c7a6ac6 Compare October 1, 2026 09:45
@chatgpt-codex-connector

This comment has been minimized.

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crACK

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex current-head review at c7a6ac6: no findings. The change only removes unfinished Clone/Backup entry points and matching README claims; it leaves the underlying scripts unreachable from the supported UI without altering installer or wallet behavior.

@BenWestgate
BenWestgate marked this pull request as draft October 5, 2026 18:46
@BenWestgate

BenWestgate commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner Author

Let's wait to do this after we have an idea if there is a even a way to Clone Bails safely or if after creating a wallet we always risk transferring some of our wallet metadata to them..

Being able to share these is a key goal of the project, however it may take upstream work to add an exclude folder to tails-cloner

Hide the unfinished Backup and Clone actions and remove README instructions that direct users into the unsupported clone flow.

Closes #42
@BenWestgate
BenWestgate force-pushed the 42-disable-backup-clone branch from c7a6ac6 to 6b31f89 Compare October 7, 2026 08:34

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-assisted current-head review: Concept ACK 6b31f89 (draft). Removing unsupported Clone/Backup entry points matches the README. No findings; restack with the final menu changes before human review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking Backup or Clone in the menu may break the installation

1 participant