๐จ Palette: ๋ ์ง ๋ฒ์ ์ ํ๊ธฐ ์ ๊ทผ์ฑ ๋ฐ ํฌ์ปค์ค ์ํ ๊ฐ์ #213
๐จ Palette: ๋ ์ง ๋ฒ์ ์ ํ๊ธฐ ์ ๊ทผ์ฑ ๋ฐ ํฌ์ปค์ค ์ํ ๊ฐ์ #213seonghobae wants to merge 11 commits into
Conversation
โฆlicate calculation `buildTimelineGroups` was calculated redundantly inside both `EventList` and `SessionActivityRibbon` inside `useMemo` hooks. This commit moves the `useMemo` computation into the parent `page.tsx` component and passes down `groups` as a prop to its children, preventing duplicate O(n) array iterations per `events` change.
Replace chained `.reduce()` and `Object.values()` with a single `for...of` loop over `Object.keys()` to avoid unnecessary intermediate array allocations and improve iteration performance during report aggregation.
overview-stats ์ปดํฌ๋ํธ์ ์ค๋ช ํ ์คํธ๋ฅผ ํผ์น๊ฑฐ๋ ์ ๋ ๋ฒํผ์ ํค๋ณด๋ ํฌ์ปค์ค ์คํ์ผ์ด ๋๋ฝ๋์ด ์์ด, ํค๋ณด๋ ๋ด๋น๊ฒ์ด์ ์ฌ์ฉ์์๊ฒ ํ์ฌ ํฌ์ปค์ค ์์น๋ฅผ ๋ช ํํ ๋ณด์ฌ์ฃผ์ง ๋ชปํ๋ ๋ฌธ์ ๋ฅผ ์์ ํ์ต๋๋ค. Tailwind CSS์ `focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring rounded-sm` ํด๋์ค๋ฅผ ์ถ๊ฐํ์ฌ ํญ(Tab) ํค ์ด๋ ์ ํฌ์ปค์ค ๋ง์ด ๋ณด์ด๋๋ก ์ ๊ทผ์ฑ์ ๊ฐ์ ํ์ต๋๋ค.
- `TokenUsageChart`์ `WeeklyFlowChart`์ ๋ฐ์ดํฐ ๋ณํ ๋ก์ง์ `useMemo`๋ฅผ ์ ์ฉํ์ฌ ๋ถํ์ํ ๋ฆฌ๋ ๋๋ง ์ต์ ํ.
โฆy-improvements-7782421783208925042
โฆdata-8534904799192449677
โฆtats-focus-1138085163110647654
โฆ-loops-in-reports-11490543380196529130
โฆline-groups-memo-10280015208843955185
- ๋ ์ง ๋ฒ์ ์ ํ๊ธฐ(Segment Control) ๋ํผ์ `role="group"` ๋ฐ `aria-label` ์ถ๊ฐ - ์ ํ๋ ๋ฒํผ ์ํ๋ฅผ ์คํฌ๋ฆฐ ๋ฆฌ๋์ ์๋ฆฌ๋ `aria-pressed` ์์ฑ ์ถ๊ฐ - ํค๋ณด๋ ๋ด๋น๊ฒ์ด์ ์ ํฌ์ปค์ค๊ฐ ๋ช ํํ ๋ณด์ด๋๋ก `focus-visible` ๊ด๋ จ ํด๋์ค ์ถ๊ฐ - DateRangePicker ์ปดํฌ๋ํธ์ ๋ํ ์ ๋ ํ ์คํธ(Vitest + jsdom) 100% ์ปค๋ฒ๋ฆฌ์ง ์์ฑ - .Jules/palette.md ์ ๋ ํญ๋ชฉ ์ถ๊ฐ
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
๐ก What: The UX enhancement added
๋ ์ง ๋ฒ์ ์ ํ๊ธฐ(Segment Control)์ ์ ๊ทผ์ฑ(Accessibility)์ ๊ฐ์ ํ์ต๋๋ค.
role="group"๊ณผaria-label="๋ ์ง ๋ฒ์ ์ ํ"์ถ๊ฐaria-pressed์์ฑ ์ถ๊ฐfocus-visible(ํฌ์ปค์ค ๋ง) ์คํ์ผ ์ถ๊ฐdate-range-picker.tsx) ์ ๋ ํ ์คํธ ์์ฑ (100% ์ปค๋ฒ๋ฆฌ์ง)๐ฏ Why: The user problem it solves
๊ธฐ์กด์๋ ํค๋ณด๋๋ก ํญ ์ด๋ ์, ํ์ฌ ๋ ์ง ๋ฒ์ ์ ํ๊ธฐ์ ํฌ์ปค์ค๊ฐ ์๋์ง ์๊ฐ์ ์ผ๋ก ํ์ธํ๊ธฐ ์ด๋ ค์ ์ต๋๋ค. ๋ํ ์คํฌ๋ฆฐ ๋ฆฌ๋ ์ฌ์ฉ์๋ ์ด๊ฒ์ด ์ฌ๋ฌ ๋ฒํผ์ด ๋ฌถ์ธ ๊ทธ๋ฃน(Segment Control)์ธ์ง, ๊ทธ๋ฆฌ๊ณ ํ์ฌ ์ด๋ ๋ฒํผ์ด ์ ํ๋ ์ํ์ธ์ง ์ ๋ฐฉ๋ฒ์ด ์์์ต๋๋ค. ์ด๋ฅผ ์น ํ์ค๊ณผ ARIA ๊ถ์ฅ ํจํด์ ๋ง๊ฒ ๊ฐ์ ํ์ฌ ํค๋ณด๋ ๋ฐ ์คํฌ๋ฆฐ ๋ฆฌ๋ ์ฌ์ฉ์์ ๊ฒฝํ์ ์ํฅ์์ผฐ์ต๋๋ค.
๐ธ Before/After
โฟ Accessibility
role="group"aria-labelaria-pressedfocus-visible:ring-2๋ฑ ์ ์ฉPR created automatically by Jules for task 14115302476240682635 started by @seonghobae