fix: compiler warnings for missing overrides#2931
Merged
Merged
Conversation
This was referenced Apr 18, 2026
Collaborator
Author
bruno-dasilva
force-pushed
the
bruno/fix-warnings-1
branch
from
37fad96 to
1ce4d45
Compare
This was referenced Apr 22, 2026
bruno-dasilva
force-pushed
the
bruno/fix-warnings-1
branch
from
1ce4d45 to
95bb4f6
Compare
sprunk
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the warning spam when compiling with clang, gcc, or msvc (mostly clang). This PR focuses just on adding the many missing overrides.
AI Disclosure
This PR was generated through running claude code in a loop to fix every warning. However, every non-trivial change was inspected and several "fixes" were dropped in favor of different solutions to try and keep backwards compatibility in mind. I've called out the couple places where I don't understand the fix or the implication of the fix to other reviewers.