fix: legit bugs found by compiler warnings#2946
Merged
Merged
Conversation
This was referenced Apr 22, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 22, 2026
bruno-dasilva
commented
Apr 22, 2026
bruno-dasilva
commented
Apr 24, 2026
bruno-dasilva
force-pushed
the
bruno/fix-warnings-4
branch
from
56344b4 to
34b90ee
Compare
bruno-dasilva
force-pushed
the
bruno/fix-warnings-5
branch
from
b80d5c0 to
26a1122
Compare
bruno-dasilva
force-pushed
the
bruno/fix-warnings-4
branch
from
34b90ee to
d2328da
Compare
bruno-dasilva
force-pushed
the
bruno/fix-warnings-5
branch
from
26a1122 to
d4120a6
Compare
Collaborator
Author
|
@sprunk this one should be good to go for a final review :) |
Collaborator
|
I resolved the individual comments where applicable, a handful are left |
bruno-dasilva
force-pushed
the
bruno/fix-warnings-4
branch
from
95ae94c to
b0d3a81
Compare
bruno-dasilva
force-pushed
the
bruno/fix-warnings-5
branch
from
d4120a6 to
f20cefb
Compare
sprunk
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the warning spam when compiling with clang, gcc, or msvc (mostly clang). This PR focuses on the "legit" bugs found when compiling with -Wall (which has a lot of nits/false positives). Wall is only used in debug builds so I'm not worried about fixing all of them.
I went through and successfully compiled every fix, and pulled the actual warning from the compiler into a review comment. And explained the associated bug.
AI Disclosure
This PR was generated through running claude code in a loop to fix every warning. However, every non-trivial change was inspected and several "fixes" were dropped in favor of different solutions to try and keep backwards compatibility in mind. I've called out the couple places where I don't understand the fix or the implication of the fix to other reviewers.