fix: compiler warnings with potential side effects#2934
Merged
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 18, 2026
bruno-dasilva
force-pushed
the
bruno/fix-warnings-4
branch
from
4161c46 to
c2846d9
Compare
bruno-dasilva
commented
Apr 18, 2026
bruno-dasilva
force-pushed
the
bruno/fix-warnings-4
branch
from
c2846d9 to
bcffd82
Compare
bruno-dasilva
force-pushed
the
bruno/fix-warnings-3
branch
from
97d068b to
2bd0c46
Compare
bruno-dasilva
force-pushed
the
bruno/fix-warnings-4
branch
from
bcffd82 to
56344b4
Compare
bruno-dasilva
force-pushed
the
bruno/fix-warnings-3
branch
from
2bd0c46 to
3cbd6c1
Compare
This was referenced Apr 22, 2026
bruno-dasilva
force-pushed
the
bruno/fix-warnings-3
branch
from
3cbd6c1 to
35ac9e8
Compare
bruno-dasilva
force-pushed
the
bruno/fix-warnings-4
branch
from
56344b4 to
34b90ee
Compare
bruno-dasilva
force-pushed
the
bruno/fix-warnings-3
branch
from
35ac9e8 to
a634fdc
Compare
bruno-dasilva
force-pushed
the
bruno/fix-warnings-4
branch
from
34b90ee to
d2328da
Compare
Collaborator
|
Looks good apart from the waterline one. I'd keep the value within integer range there |
bruno-dasilva
force-pushed
the
bruno/fix-warnings-3
branch
from
a634fdc to
6ddbfda
Compare
bruno-dasilva
force-pushed
the
bruno/fix-warnings-4
branch
from
95ae94c to
b0d3a81
Compare
sprunk
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the warning spam when compiling with clang, gcc, or msvc (mostly clang). This PR focuses on the more "potenitally breaking" fixes. Some of these are false positives (as in the underlying code has no bug) but changing the code avoids the warning. There are a few legit bugs that have slight behaviour changes.
I've gone through and successfully compiled every non-trivial fix, pulling the actual warning from the compiler into a review comment. I've added some explanations on sections where I wasn't sure whether the change was safe or why the change was made, to try and add detail for other reviewers.
AI Disclosure
This PR was generated through running claude code in a loop to fix every warning. However, every non-trivial change was inspected and several "fixes" were dropped in favor of different solutions to try and keep backwards compatibility in mind. I've called out the couple places where I don't understand the fix or the implication of the fix to other reviewers.