[default values] ORC/Spark: forward-port default-value reads via idToConstant (LI #76) - #273
Merged
Merged
Conversation
…Constant (LI #76) Twin of #267 for openhouse-1.5.2 / Spark 3.5. Omit absent defaulted fields from the ORC projection and inject them into idToConstant so the row reader fills via existing constant readers. Vectorized ORC fill stays out of scope: SparkBatch keeps defaulted projections on the row reader. Spark 3.5 already has idToConstant on SparkOrcReader; wiring goes through BaseRowReader and SparkBatch instead of Spark 3.1 BaseDataReader/SparkBatchScan.
2 tasks
Like-for-like with openhouse-1.2.0. BaseReader/SparkBatch names are required on Spark 3.5; tests keep the 1.2.0 class names and JUnit 4 runner.
17 tasks
mkuchenbecker
approved these changes
Aug 27, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openhouse-1.5.2.convertConstantLIST/MAP/STRUCT branches, same JUnit 4 tests.The only required substitutions are Spark 3.5 type names that do not exist on this branch:
BaseDataReader→BaseReader,SparkBatchScan→SparkBatch, ORC.supportsInitialDefaults()onBaseRowReaderinstead of Spark 3.1RowDataReader. Test class names and assertions are unchanged.Testing Done
:iceberg-orc:testand:iceberg-spark:iceberg-spark-3.5_2.12:testfor the default-fill testsDependencies