[Studio UI] Improve search modal layout, saved searches, and type dropdown#3882
[Studio UI] Improve search modal layout, saved searches, and type dropdown#3882idaiv wants to merge 7 commits into
Conversation
…pdown translations Search Modal: - Add "Quick Search" as the modal title - Fix content area to fill available height instead of fixed pixel height - Make All-tab results use full height with proper scrolling - Pin pagination toolbar at the bottom of the All-tab - Fill SplitLayout height between results and detail preview - Reduce spacing between filter controls for a more compact look - Remove unnecessary border styling from toolbars and top bars Saved Searches: - Fix saved searches panel not using full available height - Improve saved searches tab layout and styling Type Dropdown: - Add missing translations for newsletter, object, variant type IDs across all 7 locales (were showing as raw lowercase keys) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
| image-gallery.delete-frame: Delete Frame | ||
| text: Text | ||
| video: Video | ||
| newsletter: Newsletter |
There was a problem hiding this comment.
why do we need this translation?
There was a problem hiding this comment.
@markus-moser the ask was to sentence case all types in the search modal dropdown. Is the approach wrong? Its part of my cleaning up the wording and writing so we follow our guidelines.
There was a problem hiding this comment.
But why do we even write the word "Newsletter" somewhere? Don't get it... we do not have any newsletter feature? :)
There was a problem hiding this comment.
we had this discussed over a chat. Solution: Remove the newsletter translation, its only demo related
|
|
||
| <SplitLayout | ||
| leftItem={ | ||
| <div style={ { display: 'flex', flexDirection: 'column', height: '100%' } }> |
There was a problem hiding this comment.
Please discuss this with @vin0401 to be sure. Should we e.g. use our Flex component?
There was a problem hiding this comment.
Yep, would vote for our flex here.
| setActiveKey(key) | ||
| } } | ||
| /> | ||
| <div style={ { display: 'flex', flexDirection: 'column', height: 500 } }> |
There was a problem hiding this comment.
Please discuss this with @vin0401 to be sure. Should we e.g. use our Flex component?
There was a problem hiding this comment.
Yep, would vote for our flex here.
| type='link' | ||
| /> | ||
| {total > 0 && ( | ||
| <div style={ { position: 'absolute', top: 0, right: 0, bottom: 0, left: 0 } }> |
There was a problem hiding this comment.
Please discuss this with @vin0401. position: absolute looks strange?
There was a problem hiding this comment.
Seems to be the hack to get something stretch over the while content, any isides here @idaiv?
But I think for tabs we also already should have a build in solution.
… translation changes - Remove mock items and +3 total count hack from saved-searches-tab - Revert tree.actions.clone-user/remove-user/clone-role/remove-role translations back to original values (unrelated to search PR scope) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Hi @markus-moser! Thank you for reviewing this PR and the feedback. The part which could be solved right away is already done, the rest is up to discussion with @vin0401, therefore I will place him as a reviewer now. |
These generic type label translations are not needed for the search modal work and were added unnecessarily across all 7 locale files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Previous commit incorrectly removed object and variant keys along with newsletter. Only newsletter was requested to be removed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
3 participants
Solves: #3835
Summary