remove rapids-date-string - #272
Merged
Merged
Conversation
32 tasks
KyleFromNVIDIA
approved these changes
Aug 5, 2026
This was referenced Aug 5, 2026
cryos
pushed a commit
to NVIDIA/numbast
that referenced
this pull request
Aug 7, 2026
`rapids-date-string` is used to set the environment variable `RAPIDS_DATE_STRING`, which is not used here. It's included in a build script here, probably as an accident from copying patterns from RAPIDS projects. This removes it. ## Notes for Reviewers Noticed this because as part of rapidsai/build-planning#218, I'm removing `rapids-date-string` (rapidsai/gha-tools#272). This prevents that change from breaking CI. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated the Conda Python build process by removing an unnecessary package sourcing step. * All other build, versioning, logging, retry, and cache reporting behavior remains unchanged. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
rapids-bot Bot
pushed a commit
to rapidsai/ucx-wheels
that referenced
this pull request
Aug 7, 2026
`rapids-date-string` is used to set the environment variable `RAPIDS_DATE_STRING`, which is not used here. It's included in a wheel script here, probably as an accident from copying patterns from RAPIDS projects. This removes it. ## Notes for Reviewers Noticed this because as part of rapidsai/build-planning#218, I'm removing `rapids-date-string` (rapidsai/gha-tools#272). This prevents that change from breaking CI. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #49
jameslamb
changed the title
Member
Author
|
All uses of this are now gone (GitHub search), this can be merged. |
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#218