Skip to content

Expose lifecycle_node#327

Closed
esteve wants to merge 1 commit intoros2:rollingfrom
esteve:support-lifecycle-in-frontend
Closed

Expose lifecycle_node#327
esteve wants to merge 1 commit intoros2:rollingfrom
esteve:support-lifecycle-in-frontend

Conversation

@esteve
Copy link
Copy Markdown
Member

@esteve esteve commented Oct 4, 2022

Original author: @kenji-miyake

Closes #236

@esteve
Expose lifecycle_node
9ca0241 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@esteve esteve mentioned this pull request Oct 4, 2022
Closed
@kenji-miyake
Copy link
Copy Markdown
Contributor

kenji-miyake commented Oct 4, 2022

@esteve Thank you for your work!
But actually, since it's still a limited part, I think it won't "close" the issue.

@esteve
Copy link
Copy Markdown
Member Author

esteve commented Oct 4, 2022

@kenji-miyake thanks. I created ros2/launch#658 to address event handlers

ivanpauno
ivanpauno approved these changes Nov 9, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
It would be nice to add some tests before merging.

If we only expose this, and not event handlers, there's no much advantage of using lifecycle_node over node in XML launch files.
The only advantage is that the StateTransition and ChangeState events will be emited.
So if you include a python launch file from the XML launch file, you can take advantages of those using event handlers.
Though that seems fine IMO

@ivanpauno
Copy link
Copy Markdown
Member

ivanpauno commented Dec 5, 2022

@esteve @kenji-miyake could you add a test case for this?
Thanks!

@adityapande-1995 adityapande-1995 added the tests Failing or missing tests label Dec 12, 2022
@SuperJappie08
Copy link
Copy Markdown
Contributor

SuperJappie08 commented Aug 18, 2025

@ivanpauno @esteve @kenji-miyake, I could add some front-end tests, if you want?

This was referenced Aug 18, 2025
Closed
Merged
@SuperJappie08
Copy link
Copy Markdown
Contributor

SuperJappie08 commented Aug 23, 2025

I've added the test in a new PR #482.

christophebedard pushed a commit that referenced this pull request Oct 26, 2025
@SuperJappie08
Expose lifecycle_node (#327) (with test) (#482)
e3ef186 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
mergify bot pushed a commit that referenced this pull request Apr 12, 2026
@SuperJappie08 @mergify
Expose lifecycle_node (#327) (with test) (#482)
6dd175e 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
(cherry picked from commit e3ef186)
@mergify mergify bot mentioned this pull request Apr 12, 2026
Merged
mergify bot pushed a commit that referenced this pull request Apr 12, 2026
@SuperJappie08 @mergify
Expose lifecycle_node (#327) (with test) (#482)
e9c8d74 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
(cherry picked from commit e3ef186)
@mergify mergify bot mentioned this pull request Apr 12, 2026
Merged
mjcarroll pushed a commit that referenced this pull request Apr 13, 2026
@mergify @SuperJappie08
Expose lifecycle_node (#327) (with test) (#482) (#532)
292714a 
(cherry picked from commit e3ef186)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
Co-authored-by: Jasper van Brakel <36795178+SuperJappie08@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
ahcorde pushed a commit that referenced this pull request Apr 13, 2026
@mergify @SuperJappie08
Expose lifecycle_node (#327) (with test) (#482) (#533)
51fc37c 
(cherry picked from commit e3ef186)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
Co-authored-by: Jasper van Brakel <36795178+SuperJappie08@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

@ivanpauno ivanpauno

Labels

backlog tests Failing or missing tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support LifecycleNode and EventHandler in frontend

6 participants

@esteve @kenji-miyake @ivanpauno @SuperJappie08 @adityapande-1995 @fujitatomoya