Skip to content

Expose lifecycle_node (#327) (with test)#482

Merged
christophebedard merged 2 commits intoros2:rollingfrom
SuperJappie08:support-lifecycle-in-frontend
Oct 26, 2025
Merged

Expose lifecycle_node (#327) (with test)#482
christophebedard merged 2 commits intoros2:rollingfrom
SuperJappie08:support-lifecycle-in-frontend

Conversation

@SuperJappie08
Copy link
Copy Markdown
Contributor

@SuperJappie08 SuperJappie08 commented Aug 23, 2025

Original committer: @esteve
Original author: @kenji-miyake
Original reviewer: @ivanpauno

Description

Added the requested tests to #327, also exposed autostart.

Fixes #236

Is this user-facing behavior change?

Did you use Generative AI?

No

Additional Information

Rebased original pull request on rolling.

Kenji Miyake and others added 2 commits August 23, 2025 17:12
@SuperJappie08
Expose lifecycle_node
a276384 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@SuperJappie08
Add lifecycle node front-end test and add autostart
2c26709 
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
@SuperJappie08 SuperJappie08 mentioned this pull request Aug 23, 2025
Closed
@SuperJappie08
Copy link
Copy Markdown
Contributor Author

SuperJappie08 commented Oct 14, 2025

@fujitatomoya, this is the updated version of #327, which you closed recently.
Would you have time to review it?

fujitatomoya
fujitatomoya approved these changes Oct 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is lgtm.

@christophebedard @ahcorde i would like to have 2nd review on this. can you take a look when you have time?

@fujitatomoya
Copy link
Copy Markdown
Contributor

fujitatomoya commented Oct 20, 2025 •
edited by christophebedard
Loading

Pulls: #482
Gist: https://gist.githubusercontent.com/fujitatomoya/dc3ac29ce2fd7482d8091acdfd376795/raw/fc06bb5c62c0819740751c82b217c78322a2ce74/ros2.repos
BUILD args: --packages-above-and-dependencies launch_ros test_launch_ros
TEST args: --packages-above launch_ros test_launch_ros
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17317

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@SuperJappie08
Copy link
Copy Markdown
Contributor Author

SuperJappie08 commented Oct 22, 2025

@fujitatomoya, I think the CI failed on cloning the repos.
Would it benefit from retrying?

@christophebedard christophebedard self-requested a review October 22, 2025 16:36
@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Oct 22, 2025

I'll give this a quick review and take care of CI later today.

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Oct 22, 2025

Just to note this here:

#236 mentions supporting event handlers (i.e., the RegisterEventHandler action) in frontends. As explained in #327 (review), without this, there isn't much advantage to exposing LifecycleNode to frontends. However, as mentioned in that issue, it's still a good first step. Also, it looks like we have ros2/launch#658 for exposing RegisterEventHandler to frontends, so I think it's fine to close #236.

christophebedard
christophebedard approved these changes Oct 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We just need to wait for the CI jobs I retriggered to finish; CI queues are a bit full right now.

@christophebedard christophebedard merged commit e3ef186 into ros2:rolling Oct 26, 2025
3 checks passed
@emersonknapp emersonknapp moved this to Needs backport in roslaunch planning Nov 11, 2025
@peci1
Copy link
Copy Markdown

peci1 commented Apr 9, 2026

What about the backports? I think this one should be quite straightforward...

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Apr 12, 2026

Which distro(s) do you think this should be backported to?

@peci1
Copy link
Copy Markdown

peci1 commented Apr 12, 2026

At least Jazzy + Kilted? Jazzy is the distro where lots of launch files got rewritten to XML...

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Apr 12, 2026

@Mergifyio backport kilted jazzy

@mergify
Copy link
Copy Markdown

mergify bot commented Apr 12, 2026 •
edited
Loading

backport kilted jazzy

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Apr 12, 2026
@SuperJappie08 @mergify
Expose lifecycle_node (#327) (with test) (#482)
6dd175e 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
(cherry picked from commit e3ef186)
@mergify mergify bot mentioned this pull request Apr 12, 2026
Merged
mergify bot pushed a commit that referenced this pull request Apr 12, 2026
@SuperJappie08 @mergify
Expose lifecycle_node (#327) (with test) (#482)
e9c8d74 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
(cherry picked from commit e3ef186)
@mergify mergify bot mentioned this pull request Apr 12, 2026
Merged
mjcarroll pushed a commit that referenced this pull request Apr 13, 2026
@mergify @SuperJappie08
Expose lifecycle_node (#327) (with test) (#482) (#532)
292714a 
(cherry picked from commit e3ef186)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
Co-authored-by: Jasper van Brakel <36795178+SuperJappie08@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
ahcorde pushed a commit that referenced this pull request Apr 13, 2026
@mergify @SuperJappie08
Expose lifecycle_node (#327) (with test) (#482) (#533)
51fc37c 
(cherry picked from commit e3ef186)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com>
Co-authored-by: Jasper van Brakel <36795178+SuperJappie08@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophebedard christophebedard christophebedard approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support LifecycleNode and EventHandler in frontend

5 participants

@SuperJappie08 @fujitatomoya @christophebedard @peci1 @emersonknapp