feat: show live clock as hh:mm without seconds#10
Open
Wegi wants to merge 1 commit into
Open
Conversation
This was referenced Jul 11, 2026
Moves TimeFormat into ConanCore so it is covered by the test target, and changes the live clock format from h:mm:ss to a constant-width zero-padded hh:mm. Seconds are floored, so a minute only shows once fully elapsed.
Wegi
force-pushed
the
feat/issue-9-hhmm-display
branch
from
3e9547a to
e72fa7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9
What
The live elapsed-time clock (menu bar + popover) now renders as zero-padded
hh:mm(e.g.00:05,01:23) instead ofh:mm:ss.How
TimeFormatmoved from the app target (Support.swift) intoConanCore(TimeFormat.swift) so it is covered by the test target — call sites unchanged, views already importConanCore.TimeFormat.clockdrops seconds and zero-pads hours; seconds are floored so a minute only appears once fully elapsed.TimeFormat.human(report formatting) is unchanged, pinned by a regression test.The constant 5-character width also removes most of the width jumping addressed in #6.
Tests
New
TimeFormatTests(TDD, red→green): zero padding, seconds flooring, hour rollover, negative clamping,humanregression pin. Full suite: 35 tests green.Stack note: first of the stacked display PRs (#9 → #6 → #3); merge this one first.