test(snapshots): migrate vp migrate snap test cases#2107
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
changed the title
vp migrate cases to the PTY snapshot suite
fengmk2
force-pushed
the
migrate-migrate-snap-tests
branch
from
32e26d3 to
a5f5ca9
Compare
fengmk2
force-pushed
the
migrate-migrate-snap-tests
branch
2 times, most recently
from
9dd2dc6 to
576fd3b
Compare
fengmk2
force-pushed
the
migrate-migrate-snap-tests
branch
from
66d9141 to
f4cc891
Compare
fengmk2
changed the base branch from
graphite-base/2107
to
fix-snap-registry-teardown
fengmk2
force-pushed
the
fix-snap-registry-teardown
branch
from
9b411d2 to
cfbc122
Compare
fengmk2
force-pushed
the
migrate-migrate-snap-tests
branch
from
f4cc891 to
b9499f0
Compare
fengmk2
changed the title
vp migrate cases to the PTY snapshot suitevp migrate snap test cases
This was referenced Jul 9, 2026
fengmk2
force-pushed
the
migrate-migrate-snap-tests
branch
from
b9499f0 to
136ae2f
Compare
fengmk2
force-pushed
the
fix-snap-registry-teardown
branch
from
8397ec3 to
cfbc122
Compare
fengmk2
force-pushed
the
migrate-migrate-snap-tests
branch
from
136ae2f to
08df764
Compare
fengmk2
force-pushed
the
migrate-migrate-snap-tests
branch
from
08df764 to
74811d1
Compare
fengmk2
force-pushed
the
fix-snap-registry-teardown
branch
from
cfbc122 to
52ce2b9
Compare
fengmk2
force-pushed
the
graphite-base/2107
branch
from
52ce2b9 to
9247583
Compare
fengmk2
force-pushed
the
migrate-migrate-snap-tests
branch
from
74811d1 to
616c94e
Compare
fengmk2
force-pushed
the
migrate-migrate-snap-tests
branch
from
616c94e to
e413787
Compare
wan9chi
approved these changes
Jul 10, 2026
Merge activity
|
Migrates all 149 legacy `vp migrate` snap-test cases (144 from `snap-tests-global`, 5 from `snap-tests`) to the PTY snapshot suite under `crates/vite_cli_snapshots`, and removes the legacy dirs. Part of #2078. Adds `redact.rs` rules for the managed-toolchain versions that appear in `vp migrate` output and bump on release: the completion banner (`Migrated . to Vite+ <version>`), the version-change table's managed rows (vite-plus, vite, vitest, `@vitest/*`, keeping the installed-source column), and the bundled vitest pins written into catalogs/overrides. The `not-supported-vite6`/`vitest3` cases stub `node_modules/<pkg>/package.json` instead of running a network `vp install`, so migrate reads the unsupported version offline. Stacked on #2115 (local-registry teardown signal fix), which the Linux snapshot job needs.
graphite-app
Bot
force-pushed
the
migrate-migrate-snap-tests
branch
from
e413787 to
3b4829e
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
Jul 10, 2026
Stacked on #2107. Migrates 7 of the 11 legacy `shim-*` global snap-test cases (node/npm/pnpm shim behavior) to the PTY snapshot suite: - `shim-inherits-parent-{dev-engines-runtime,engines-node,node-version}` - `shim-npm-uses-package-manager-version` - `shim-npm-ignores-mismatched-package-manager` - `shim-pnpm-uses-project-node-version` - `shim-recursive-npm-run` The `test "$(npm --version)" = X` version assertions become direct `npm`/`npx --version` steps whose pinned output is the snapshot. `npx` is added to the runner program allow-list (resolved from the case PATH, so the vp-managed shim wins). Deferred to a later batch, since they depend on shell features the PTY runner intentionally does not provide (`$VP_HOME` path references, `$(pwd)`/PATH overrides, fake runtimes, arbitrary installed binaries): `shim-corepack-bundled`, `shim-corepack-enable-install-directory`, `shim-npm-downloads-uncached-package-manager-version`, `shim-recursive-package-binary`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates all 149 legacy
vp migratesnap-test cases (144 fromsnap-tests-global, 5 fromsnap-tests) to the PTY snapshot suite undercrates/vite_cli_snapshots, and removes the legacy dirs. Part of #2078.Adds
redact.rsrules for the managed-toolchain versions that appear invp migrateoutput and bump on release: the completion banner (Migrated . to Vite+ <version>), the version-change table's managed rows (vite-plus, vite, vitest,@vitest/*, keeping the installed-source column), and the bundled vitest pins written into catalogs/overrides.The
not-supported-vite6/vitest3cases stubnode_modules/<pkg>/package.jsoninstead of running a networkvp install, so migrate reads the unsupported version offline.Stacked on #2115 (local-registry teardown signal fix), which the Linux snapshot job needs.