test(snapshots): migrate the local npm install case to the PTY snapshot suite#2119
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
17 tasks
wan9chi
approved these changes
Jul 10, 2026
fengmk2
force-pushed
the
migrate-npm-snap-tests
branch
from
3930c44 to
8afe918
Compare
fengmk2
force-pushed
the
fix-snap-registry-teardown
branch
from
cfbc122 to
52ce2b9
Compare
fengmk2
force-pushed
the
graphite-base/2119
branch
from
52ce2b9 to
677e59c
Compare
fengmk2
force-pushed
the
migrate-npm-snap-tests
branch
from
8afe918 to
4715cb1
Compare
This was referenced Jul 10, 2026
fengmk2
changed the base branch from
graphite-base/2119
to
migrate-vite-snap-tests
This was referenced Jul 10, 2026
fengmk2
force-pushed
the
migrate-vite-snap-tests
branch
from
677e59c to
cf1e623
Compare
fengmk2
force-pushed
the
migrate-npm-snap-tests
branch
from
4715cb1 to
77eb0ca
Compare
fengmk2
force-pushed
the
migrate-vite-snap-tests
branch
from
cf1e623 to
d77b85d
Compare
fengmk2
force-pushed
the
migrate-npm-snap-tests
branch
from
77eb0ca to
70b31aa
Compare
Merge activity
|
…shot suite (#2119) Migrates npm-install-with-options (the one local npm-* case) from packages/cli/snap-tests to the PTY snapshot suite, and removes the legacy dir. The 10 npm-global-* cases stay in the legacy tree for now: they rely on shell primitives the no-shell runner cannot yet express (test -L symlink checks, $VP_HOME / $(pwd) expansion, invoking the installed global CLIs, dynamic NPM_CONFIG_PREFIX), which need new vpt/runner support. Part of #2116.
graphite-app
Bot
force-pushed
the
migrate-vite-snap-tests
branch
from
d77b85d to
4c16d78
Compare
graphite-app
Bot
force-pushed
the
migrate-npm-snap-tests
branch
from
70b31aa to
8ad49e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates npm-install-with-options (the one local npm-* case) from$VP_HOME / $ (pwd) expansion, invoking the installed
packages/cli/snap-tests to the PTY snapshot suite, and removes the legacy
dir. The 10 npm-global-* cases stay in the legacy tree for now: they rely
on shell primitives the no-shell runner cannot yet express (test -L
symlink checks,
global CLIs, dynamic NPM_CONFIG_PREFIX), which need new vpt/runner support.
Part of #2116.