test(snapshots): migrate vp check cases to the PTY snapshot suite#2117
Merged
Conversation
This was referenced Jul 9, 2026
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 9, 2026
fengmk2
force-pushed
the
migrate-check-snap-tests
branch
from
fdfb34c to
fb7065b
Compare
fengmk2
force-pushed
the
fix-snap-registry-teardown
branch
from
8397ec3 to
cfbc122
Compare
fengmk2
force-pushed
the
migrate-check-snap-tests
branch
from
fb7065b to
32b2c85
Compare
fengmk2
force-pushed
the
fix-snap-registry-teardown
branch
from
cfbc122 to
52ce2b9
Compare
fengmk2
force-pushed
the
migrate-check-snap-tests
branch
from
32b2c85 to
147f6a8
Compare
fengmk2
force-pushed
the
graphite-base/2117
branch
from
52ce2b9 to
b1d4b85
Compare
fengmk2
force-pushed
the
migrate-check-snap-tests
branch
from
147f6a8 to
78da4ce
Compare
fengmk2
changed the base branch from
graphite-base/2117
to
migrate-shim-snap-tests
fengmk2
force-pushed
the
migrate-check-snap-tests
branch
from
78da4ce to
d0500da
Compare
fengmk2
force-pushed
the
migrate-shim-snap-tests
branch
from
d8a042d to
caea915
Compare
fengmk2
force-pushed
the
migrate-check-snap-tests
branch
from
d0500da to
2778262
Compare
wan9chi
approved these changes
Jul 10, 2026
Merge activity
|
…2117) Migrates the 30 hand-convertible `check-*` cases from `packages/cli/snap-tests` to the PTY snapshot suite under `crates/vite_cli_snapshots`, and removes the legacy dirs. The 4 `check-pass*` cases were already covered by net-new fixtures on main (same env + `vp check`), so their redundant legacy dirs are removed too. `fmt-check-with-vite-config` is left in place for the fmt migration. Part of #2116.
graphite-app
Bot
force-pushed
the
migrate-shim-snap-tests
branch
from
caea915 to
9a4fadd
Compare
graphite-app
Bot
force-pushed
the
migrate-check-snap-tests
branch
from
2778262 to
982be5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the 30 hand-convertible
check-*cases frompackages/cli/snap-teststo the PTY snapshot suite undercrates/vite_cli_snapshots, and removes the legacy dirs. The 4check-pass*cases were already covered by net-new fixtures on main(same env +
vp check), so their redundant legacy dirs are removed too.fmt-check-with-vite-configis left in place for the fmt migration.Part of #2116.